fix: pass streamdeck cli validate errors and warnings#38
Open
deverman wants to merge 3 commits intoemorydunn:mainfrom
Open
fix: pass streamdeck cli validate errors and warnings#38deverman wants to merge 3 commits intoemorydunn:mainfrom
deverman wants to merge 3 commits intoemorydunn:mainfrom
Conversation
…dd build instructions to counter plugin, modify protocol to support required uuid
Owner
|
Thanks for putting this together. Not sure when the UUID was added to the manifest, I don't see it in the SDK changelog. I'll take a look at the changes over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to validate the plug-in I am creating with the StreamDeck CLI tool I found that the manifest.json was missing the UUID for the plugin which is required.
I modified the PluginManifest.swift and StreamDeckPlugin.swift to support outputting the UUID to the manifest.json file.
To test this I built and validated the counter plugin. In doing so there were some additional validation errors.
To make sure there is a shared understanding how to build the plugins I created README.md in the counter example directory.
Let me know if you need any clarifications or changes to this PR.