Fix dlsym_catchup error with ASYNCIFY#26155
Open
wenhanchong wants to merge 1 commit intoemscripten-core:mainfrom
Open
Fix dlsym_catchup error with ASYNCIFY#26155wenhanchong wants to merge 1 commit intoemscripten-core:mainfrom
wenhanchong wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
|
I wonder if we could come up with test case for this? (maybe by modifying an the existing test?) |
sbc100
reviewed
Jan 26, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Can you describe how you managed to run into this issue? i.e. how can we reproduce it so that we can create a test.
Contributor
Author
|
My app was loading a nested wasm side module (side module dylinking another side module) when I encountered this issue. Was using ASYNCIFY=2, PTHREADS and PROXY_TO_PTHREAD. I tried reproducing it in a separate sample app but it didn't call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for
dlsym_catchup_jserror withASYNCIFY.Aborted(Assertion failed: Missing signature argument to addFunction: (...args) => original(...args)). WithASYNCIFY, exports are wrapped so we need to pass original toaddFunction.