Fix fd_sync under pthreads #26211
Open
Fix fd_sync under pthreads #26211
+29
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is marked as `__async: 'auto'` which means it should return a promise when run in proxied mode on the main thread. However it wasn't always returning a promise. Adding the `async` keyword is the simplest way to ensure it always returns a promise. Also, update the `wrapSyscallFunction` function to preserve the async keyword. Replaces: emscripten-core#26209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is marked as
__async: 'auto'which means it should return a promise when run in proxied mode.Also, update the
wrapSyscallFunctionfunction to preserve the async keyword. This fix was needed when investigating using theasynckeyword instead. Even though it didn't end up working in this case its still a worthwhile fix.Replaces: #26209