[Bazel] Support for a custom prebuilt emscripten cache#1620
Open
DoDoENT wants to merge 3 commits intoemscripten-core:mainfrom
Open
[Bazel] Support for a custom prebuilt emscripten cache#1620DoDoENT wants to merge 3 commits intoemscripten-core:mainfrom
DoDoENT wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
Collaborator
|
@walkingeyerobot can you recommend anyone else who might be good to review this? |
f260754 to
89182a9
Compare
89182a9 to
ac529c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for using a prebuilt cache as an archive instead of building it from scratch every time.
This solves multiple problems:
thinlto,lto, and other cache combinations on demand. This doesn't work in the Bazel world, where the cache needs to be frozen.emscripten_configfile that contained full path to the cache.emscripten_configfile is always same, regardless of the machineAfter applying this patch to our internal codebase, the regular builds of WASM code went down from 12-15 minutes to cca 30 seconds, regardless on which machine it runs, as long as remote cache is warm.