Skip to content

[Bazel] Applying buildifier -lint=fix -r .#1649

Open
Vertexwahn wants to merge 2 commits intoemscripten-core:mainfrom
Vertexwahn:bazel-9-support
Open

[Bazel] Applying buildifier -lint=fix -r .#1649
Vertexwahn wants to merge 2 commits intoemscripten-core:mainfrom
Vertexwahn:bazel-9-support

Conversation

@Vertexwahn
Copy link

@Vertexwahn Vertexwahn commented Jan 20, 2026 •
edited
Loading

  • Applying buildifier -lint=fix -r . to support Bazel 9.0.0
  • Bump rules_cc

@Vertexwahn Vertexwahn changed the title Applying buildifier -lint=fix -r . [bazel] Applying buildifier -lint=fix -r . Jan 20, 2026
@Vertexwahn Vertexwahn changed the title [bazel] Applying buildifier -lint=fix -r . [Bazel] Applying buildifier -lint=fix -r . Jan 20, 2026
@Vertexwahn Vertexwahn mentioned this pull request Jan 20, 2026
Open
@sbc100
Copy link
Collaborator

sbc100 commented Jan 20, 2026

Seems reasonable once the tests pass.

@sbc100
Copy link
Collaborator

sbc100 commented Jan 22, 2026

CI is failing with:

ERROR: Traceback (most recent call last):
        File "/root/project/bazel/emscripten_toolchain/toolchain.bzl", line 1149, column 43, in <toplevel>
                emscripten_cc_toolchain_config_rule = rule(
Error in rule: at index 0 of provides, got element of type NoneType, want Provider

however I think that might be pre-existing?

Any ideas?

@sbc100 sbc100 mentioned this pull request Jan 26, 2026
Merged
sbc100 added a commit that referenced this pull request Jan 26, 2026
@sbc100
Temporarily disable bazel-latest testing. NFC (#1663)
75ba526 
These jobs have been failing for a long time now. We can re-enable them
once we fix support for the bazel latest.

See #1649, #1642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walkingeyerobot walkingeyerobot Awaiting requested review from walkingeyerobot

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vertexwahn @sbc100