Conversation
Putting the gameConfig into a module instead of creating a class was a bad design decision. Not refactoring the core game for now. Therefore this will coexist with the old `config.py`
Patch the statistics2 parser to make it pass the new study setting to get a baseline for the rewritten parser
- `[object Object]` was shown instead of stack trace - Pseudonyms starting with 0 where not logged at all - Removed field `origin` since this info is already contained in stacktrace
In JavaScript you can throw literally anything as an error which will not have a stack trace and needs to be serialized as well
…e compatibility layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
setInteractive()to be called earlyChanges: