Conversation
Contributor
|
Are the bindings generated this way actually compatible with what we have before? What disadvantages are there? |
Author
|
it definitely breaks lldb.rs. here some reasoning: pro:
con:
for now my honest opinion is to not seriously attempt to merge this PR. I like lldb and always wanted to play with it. maybe i get some time to play with lldb.rs and can come back with more facts. until then I would treat this more like a proof of concept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i tried to generate the bindings dynamically directly from the lldb headers but they would not work. I assume you hit the same as you rewrote the lldb API to wrap all returned objects and move them to the heap.
i spend some time and found the reason and a workaround.