This repository was archived by the owner on Sep 15, 2023. It is now read-only.
fix: filesystem cache handler with url params#39
Open
mjastrzebowski wants to merge 1 commit intoeneajaho:mainfrom
Open
fix: filesystem cache handler with url params#39mjastrzebowski wants to merge 1 commit intoeneajaho:mainfrom
mjastrzebowski wants to merge 1 commit intoeneajaho:mainfrom
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @eneajaho on Vercel. @eneajaho first needs to authorize it. |
mjastrzebowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server crashes whenever trying to cache with
FileSystemCacheHandlersome route with url params, eg./search?term=testor/category/example?page=4- might be problem on Windows only as mentioned in #38 that you can't create file with special characters, but IMO in general it would be good to have more safe filenames.Basically replacing all special characters from route is fixing the main problem, in the future I will also take a look into angular prerendering itself (also breaks on special characters right now) and might need some changes to
convertFileNameToRoutemethod as well.Solves #38