Force extension with --use-ext#23
Open
jleonardolemos wants to merge 2 commits intoenlightn:mainfrom
jleonardolemos:force-extension
Open
Force extension with --use-ext#23jleonardolemos wants to merge 2 commits intoenlightn:mainfrom jleonardolemos:force-extension
jleonardolemos wants to merge 2 commits intoenlightn:mainfrom
jleonardolemos:force-extension
Conversation
Member
|
Thanks @jleonardolemos, appreciate your contributions 👍 I'll try and get this in by the end of the week. Been busy with some stuff lately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Add an
--use-extoption in order to provide a way to force a specific zip tool as the follow:We can use
system-unzipforce system unzip command andzip-extensionto force PHP Zip Extension and any other option will be silently ignored.Some considerations:
zip-extensionexplicitly and the zip extension is not installed than an exception will be thrown, should it be handled?system-unzipexplicitly and the unzip command does not exists than an error will happen, should it be handled?newoperator i was not able to test very well without very clumsy mock strategies, i just wrote a test to ensure that ti code is running fine and nothing is broken.