Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions source/extensions/filters/http/header_mutation/config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,21 @@ HeaderMutationFactoryConfig::createFilterFactoryFromProtoTyped(
};
}

Http::FilterFactoryCb
HeaderMutationFactoryConfig::createFilterFactoryFromProtoWithServerContextTyped(
const ProtoConfig& config, const std::string&,
Server::Configuration::ServerFactoryContext& context) {
absl::Status creation_status = absl::OkStatus();
auto filter_config = std::make_shared<HeaderMutationConfig>(config, context, creation_status);
if (!creation_status.ok()) {
ExceptionUtil::throwEnvoyException(std::string(creation_status.message()));
}

return [filter_config](Http::FilterChainFactoryCallbacks& callbacks) -> void {
callbacks.addStreamFilter(std::make_shared<HeaderMutation>(filter_config));
};
}

absl::StatusOr<Router::RouteSpecificFilterConfigConstSharedPtr>
HeaderMutationFactoryConfig::createRouteSpecificFilterConfigTyped(
const PerRouteProtoConfig& proto_config, Server::Configuration::ServerFactoryContext& context,
Expand Down
5 changes: 5 additions & 0 deletions source/extensions/filters/http/header_mutation/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ class HeaderMutationFactoryConfig
createFilterFactoryFromProtoTyped(const ProtoConfig& proto_config,
const std::string& stats_prefix, DualInfo info,
Server::Configuration::ServerFactoryContext& context) override;

Http::FilterFactoryCb createFilterFactoryFromProtoWithServerContextTyped(
const ProtoConfig& proto_config, const std::string& stats_prefix,
Server::Configuration::ServerFactoryContext& context) override;

absl::StatusOr<Router::RouteSpecificFilterConfigConstSharedPtr>
createRouteSpecificFilterConfigTyped(const PerRouteProtoConfig& proto_config,
Server::Configuration::ServerFactoryContext&,
Expand Down
28 changes: 28 additions & 0 deletions test/extensions/filters/http/header_mutation/config_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,34 @@ TEST(FactoryTest, QueryParameterMutationsTest) {
ASSERT_NE(factory, nullptr);
}

TEST(FactoryTest, FactoryTestWithServerContext) {
testing::NiceMock<Server::Configuration::MockServerFactoryContext> mock_server_context;
auto* factory =
Registry::FactoryRegistry<Server::Configuration::NamedHttpFilterConfigFactory>::getFactory(
"envoy.filters.http.header_mutation");
ASSERT_NE(factory, nullptr);

const std::string config = R"EOF(
mutations:
request_mutations:
- remove: "flag-header"
- append:
header:
key: "flag-header"
value: "%REQ(ANOTHER-FLAG-HEADER)%"
append_action: APPEND_IF_EXISTS_OR_ADD
)EOF";

ProtoConfig proto_config;
TestUtility::loadFromYaml(config, proto_config);

auto cb = factory->createFilterFactoryFromProtoWithServerContext(proto_config, "test",
mock_server_context);
Http::MockFilterChainFactoryCallbacks filter_callbacks;
EXPECT_CALL(filter_callbacks, addStreamFilter(_));
cb(filter_callbacks);
}

} // namespace
} // namespace HeaderMutation
} // namespace HttpFilters
Expand Down
Loading