xds: add LEDS (Locality Endpoint Discovery Service) support#1390
Open
wdauchy wants to merge 1 commit intoenvoyproxy:mainfrom
Open
xds: add LEDS (Locality Endpoint Discovery Service) support#1390wdauchy wants to merge 1 commit intoenvoyproxy:mainfrom
wdauchy wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Contributor
valerian-roche
left a comment
There was a problem hiding this comment.
Overall makes sense. Would need some testing with envoy to confirm it all works together
Wire up the LocalityEndpointDiscoveryService which allows discovering LbEndpoint resources via delta xDS, as an alternative to inlining endpoints in the EDS ClusterLoadAssignment response. Signed-off-by: William Dauchy <william.dauchy@datadoghq.com>
3774420 to
f3298f0
Compare
Contributor
Author
I was hoping we could merge this initial PR which only adds types for coherency. I will followup with sub sequent PR to have proper support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up the LocalityEndpointDiscoveryService which allows discovering LbEndpoint resources via delta xDS, as an alternative to inlining endpoints in the EDS ClusterLoadAssignment response.