Invert bits to render correctly on browsers which do not render whitespace character correctly#17
Open
bradenhirschi wants to merge 1 commit intoepidemian:masterfrom
Open
Invert bits to render correctly on browsers which do not render whitespace character correctly#17bradenhirschi wants to merge 1 commit intoepidemian:masterfrom
bradenhirschi wants to merge 1 commit intoepidemian:masterfrom
Conversation
Author
|
Totally understand if this is not wanted, but it is one fix to the problem |
Owner
|
Hey @bradenhirschi, just wanted to let you know i noticed this PR, but i haven't had time to review this properly yet. I have some initial reservations about this approach (i've tried it in the past, and discarded it). But also, i feel i need to really play the game for a while in this mode to really have an informed opinion about it. I'll report back when having done so hehe. Thanks very much for the PR though; much appreciated :) |
Author
|
No worries, like I said I understand if this isn't the desired appearance. I do think that it is at least a good solution you could offer for browsers where the whitespace character isn't rendered right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screencast_20251017_113418.webm
This update inverts the bits so that dots are used for the game's background and empty space is used for the player and the target object (food?). This allows the game to render correctly on browsers which do not render the whitespace character correctly (which seems to be most browsers lol)