only set pidAttrs when child.Process is not nil#363
Open
msarahan wants to merge 1 commit intoequinix-labs:mainfrom
Open
only set pidAttrs when child.Process is not nil#363msarahan wants to merge 1 commit intoequinix-labs:mainfrom
msarahan wants to merge 1 commit intoequinix-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm observing a crash with the following example program:
otel-cli exec 'echo moo'This is mean to create a subprocess that sets TRACEPARENT such that the subprocess propagates the trace and the subprocess appears as a child.
FWIW, this works ok:
I built the project from source with a debugger, and found that with these arguments, the child.Process object is nil. I don't know if this is a bug, or if I'm just doing things wrong. Feel free to close this PR if I'm just doing things wrong, or if my approach will have unanticipated consequences.