Support AWS Direct Connect Gateway with option to create#17
Support AWS Direct Connect Gateway with option to create#17nickzxcv wants to merge 5 commits intoequinix-labs:mainfrom
Conversation
|
One thing this doesn't do, is support creating 1 DX Gateway with multiple connections attached, if there is a count for the connections it will create separate DX Gateways for each connection which isn't really what's wanted I think for adjusting capacity of connections. This behavior is consistent though with the create vgw option. |
|
Thanks for the issue and |
|
Sorry - my corgi is trying to play, mouthed my typing hand, and accidentally closed the PR 😅 🐕 Thanks for the issue and PR! This looks good overall (plus I should also mention that this module is currently based on the v3 ECX API Terraform resources, which are deprecated: equinix/terraform-provider-equinix#445 (cc @thogarty) There has been some conversation about moving the examples/ from the Terraform provider repo into modules such as this one or refactoring modules such as this one to take advantage of a new central module (or revising https://github.com/equinix-labs/terraform-equinix-fabric-connection, which this module depends on). Here is the AWS example based on the v4 Fabric API Terraform resources: |
ocobles
left a comment
There was a problem hiding this comment.
Thank you so much @nickzxcv for your contribution with this PR 👏🏼 I requested some changes that I found by testing it myself. It seems amazon_side_asn is mandatory in aws_dx_gateway, so I set a default value 64512, but please change it If you think there is a better default value.
Co-authored-by: Óscar Cobles <68897552+ocobles@users.noreply.github.com>
Co-authored-by: Óscar Cobles <68897552+ocobles@users.noreply.github.com>
Co-authored-by: Óscar Cobles <68897552+ocobles@users.noreply.github.com>
|
Thanks for the feedback! Let me know if we should make any more changes or if it should all be applied somehow differently to the newer API. |
Fixes #16