Fix Issue (#2092): Label transactions with inputs not using blockchain context, simplify their revalidation in mempool #2280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, all mempool transactions are fully revalidated on each cleanup cycle, which is computationally expensive. Many transactions don't use blockchain context (like HEIGHT, CONTEXT.headers, etc.) in their spending conditions, so their validity doesn't change with new blocks - only their inputs' existence matters.
Solution
This PR implements optimization for mempool transaction revalidation by:
Extended UnconfirmedTransaction class with new fields:
isUsingBlockchainContext: Option[Boolean]- flag indicating if any input's ErgoTree uses blockchain contextvalidationResult: Option[Boolean]- cached validation result for transactions using blockchain contextUpdated validation in ErgoMemPool (process method):
isUsingBlockchainContextflag setOptimized CleanupWorker.validatePool:
Benefits
Dependencies
isUsingBlockchainContextto ErgoTree sigmastate-interpreter#929)ErgoTree.header.isUsingBlockchainContextbecomes available