Fix ContextExtension serialization order#843
Open
Luivatra wants to merge 1 commit intoergoplatform:developfrom
Open
Fix ContextExtension serialization order#843Luivatra wants to merge 1 commit intoergoplatform:developfrom
Luivatra wants to merge 1 commit intoergoplatform:developfrom
Conversation
Match the Scala 2.12 HashMap iteration order for ContextExtension serialization when there are 5 or more entries. This is necessary to maintain compatibility with the Ergo node, which uses Scala 2.12's HashMap. For fewer than 5 entries, the existing insertion order preservation is maintained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause: Issue #763
When a ContextExtension has 5+ entries, the Ergo node (Scala 2.12) serializes them in HAMT hash-based order, not sorted/insertion order. sigma-rust used insertion order for all sizes, causing bytes_to_sign to differ, which makes the TxId different,
which invalidates the proof signature.
Threshold behavior:
The Fix
Single file modified: ergotree-ir/src/chain/context_extension.rs
What was added:
Tests added (4):