applies P1207 #1527
Closed
applies P1207 #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* relaxes weakly_incrementable * adds rvalue member functions for * move_iterator * counted_iterator * adds test for move-only weakly_incrementable
ericniebler
requested changes
Jul 8, 2020
Owner
ericniebler
left a comment
ericniebler
left a comment
There was a problem hiding this comment.
There is a lot more to supporting move-only iterators in range-v3 than tweaking the concepts. This needs to be baked throughout the whole library. There are tons of places that assume iterators are copyable. There's a reason why this hasn't been done yet. It's a ton of work.
I can't accept this diff as it currently stands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be a minor (undetected) merge conflict between this PR and #1526.