inets improve httpd do/1 callback docs and spec#10602
Open
Whaileee wants to merge 1 commit intoerlang:maintfrom
Open
inets improve httpd do/1 callback docs and spec#10602Whaileee wants to merge 1 commit intoerlang:maintfrom
inets improve httpd do/1 callback docs and spec#10602Whaileee wants to merge 1 commit intoerlang:maintfrom
Conversation
Contributor
CT Test Results 2 files 23 suites 13m 26s ⏱️ Results for commit af352b8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
lib/inets/src/http_server/httpd.erl
Outdated
Comment on lines
871
to
872
Contributor
There was a problem hiding this comment.
Suggested change
| > It is strongly advised to use `NewDataFormat` in the return value of `do/1` | |
| > as it uses a different mechanism to send the headers and the body. |
"different" doesn't mean anything to users I guess (at least, not to me 😅). Is it better? How so?
Contributor
Author
There was a problem hiding this comment.
That's true. I'll use better wording. Good catch
Whaileee
force-pushed
the
whaileee/inets/httpd/docs/do/OTP-19952
branch
from
a87334e to
af352b8
Compare
Maria-12648430
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement in a response to #10501