Add middlebox_comp_mode to global options#2989
Merged
ferd merged 1 commit intoerlang:mainfrom Jan 22, 2026
Merged
Conversation
ferd
approved these changes
Jan 22, 2026
Collaborator
ferd
left a comment
There was a problem hiding this comment.
Makes sense as an extra option; re-running failed MacOS suite to see if it was transient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds another option (like
ssl_verify) to the globalrebar.config:middlebox_comp_mode.This is needed to address issues like #2987.
The option is basically passed down as-is (with the default being
true) tohttpc:request/5where it's used as described in the docs. That is…