Conversation
This allows associating the plugin with the 'depend' namespace in flat config; otherwise ESLint would error out because the plugin instances in the user's configuration file and in the 'recommended' config aren't the same, while both tentatively associated to the same namespace. This should allow using eslint-plugin-depend from the command line with `eslint --plugin depend --rule 'depend/ban-dependencies: error'`
This allows referencing the config in string form in a flat
config `extends` with the `defineConfig` helper:
plugins: { depend },
extends: [ 'depend/flat/recommended' ],
43081j
reviewed
Apr 4, 2025
|
|
||
| const plugin: ESLint.Plugin = {rules}; | ||
| const plugin: ESLint.Plugin = { | ||
| meta: {name, version}, |
Contributor
There was a problem hiding this comment.
if all plugins had this, its probably what ESLint should actually be comparing by 👀
43081j
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43