Conversation
|
we shouldn't need to rewrite all the imports to we'd only need to do that if we wanted to run something with node's type stripping enabled, and we don't you're running into that because node is mistakenly trying to run the tests natively and shouldn't. the repo is setup such that the FYI this is a bit of a mess node caused. i dont remember the versions, but in node 20 (?) the test runner doesn't support passing a glob, but latest node does. so we can't globally pass a glob to tell it to stop matching |
|
I'm not sure I follow here, I can't find any js files in the repo? |
|
from the build eslint-plugin-depend/package.json Line 18 in ab547a2 the tests run the build first and run the node is misbehaving here, the intention was never to run the |
|
Ah I see, is there a reason to not use native node TS support and extensions, other than running tests against the built files? |
|
we were testing against node versions that didn't have type stripping, and it can be nice to test against the code we're actually going to ship the two possible solutions here are:
the latter is what you have here. but it sucks to have to do that, because we're not building for a runtime that can run i'd rather just move to vitest and accept the node test runner has been botched until we're at a point where 20.x is no longer LTS |
|
@43081j I have refactored the tests to use vitest now |
This reverts commit 875def3.
This PR started as just replacing
fd-package-jsonbut quickly spiraled as I found issues running tests etc.fd-package-jsonwithempathic.tsextensionsWe should also make sure to update semver later to the latest version as it has released a bunch of perf improvements!