-
-
Notifications
You must be signed in to change notification settings - Fork 75
fix: remove special handling of sourceType for TypeScript parser #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Tanujkanti4441
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
|
I think the following should be updated to use |
|
Also, the following doesn't seem necessary if we are no longer using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now on selecting @typescript-eslint/paser the Source Type option is empty, as #915 (comment) suggests to use the default value for sourceType, so can we also add (default) option on Source Type for tsparser as well like we have for espree?
Looks like we don't need separate lists of Source Type values for Espree and |

Prerequisites checklist
What is the purpose of this pull request?
Removing the special behaviour for the TypeScript parser.
What changes did you make? (Give an overview)
This PR includes two fixes:
sourceTypeof "module" for the TypeScript parser (refs Bug: Playground ignores sourceType when using @typescript-eslint/parser #910)languageOptionsproperties from nestedparserOptions#891 by setting thesourceTypeonlanguageOptionsinstead oflanguageOptions.parserOptionswhen swapping the parser.Related Issues
Fixes #891 and #910.
Is there anything you'd like reviewers to focus on?
Please also try various variations of updating the configuration and the resulting configuration file.