Skip to content

Conversation

@aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Feb 1, 2026

Prerequisites checklist

What is the purpose of this pull request?

This pull request makes minor updates to the ESLint configuration and dependencies in the plugin template. The changes update the ESLint plugin recommendation and bump the version of a development dependency.

  • ESLint Configuration Update:

    • Changed the extends field in eslint.config.mjs from eslint-plugin/flat/recommended to eslint-plugin/recommended to use the standard recommended configuration.
  • Dependency Update:

    • Upgraded eslint-plugin-eslint-plugin in package.json from version ^6.0.0 to ^7.3.0 for improved compatibility and features.

What changes did you make? (Give an overview)

refs: https://github.com/eslint-community/eslint-plugin-eslint-plugin/releases/tag/v7.0.0

Related Issues

Is there anything you'd like reviewers to focus on?

Copilot AI review requested due to automatic review settings February 1, 2026 16:06
@eslintbot eslintbot added this to Triage Feb 1, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Feb 1, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ESLint plugin template to use the latest eslint-plugin-eslint-plugin and its corresponding recommended flat config.

Changes:

  • Bumped the eslint-plugin-eslint-plugin devDependency in plugin/templates/_package.json from ^6.0.0 to ^7.3.0.
  • Updated plugin/templates/_eslint.config.mjs to extend eslint-plugin/recommended instead of eslint-plugin/flat/recommended, aligning the template config with the new plugin version’s recommended export.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugin/templates/_package.json Updates the eslint-plugin-eslint-plugin devDependency to ^7.3.0 in the plugin template.
plugin/templates/_eslint.config.mjs Adjusts the ESLint flat config to use the eslint-plugin/recommended preset for the eslint-plugin ruleset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aladdin-add aladdin-add moved this from Needs Triage to Implementing in Triage Feb 1, 2026
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I support and 👍 this change, but I have another question: why did eslint-plugin-eslint-plugin choose the Node.js version range "^20.19.0 || ^22.13.1 || >=24.0.0"?

https://github.com/eslint-community/eslint-plugin-eslint-plugin/blob/main/package.json#L94

It seems that if someone uses 22.13.0, it won't be supported, since generator-eslint uses the following version range:

"node": "^20.19.0 || ^22.13.0 || >=24"

@lumirlumir lumirlumir moved this from Implementing to Triaging in Triage Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Triaging

Development

Successfully merging this pull request may close these issues.

2 participants