Prefer the Ssid type over Strings and byte arrays #4953
+148
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/hil full |
|
Triggered full HIL run for #4953. Run: https://github.com/esp-rs/esp-hal/actions/runs/21873593677 Status update: ✅ HIL (full) run succeeded. |
Comment on lines
606
to
616
| pub(crate) fn new(ssid: &str) -> Self { | ||
| let mut ssid_bytes = [0u8; 32]; | ||
| let bytes = ssid.as_bytes(); | ||
| let len = usize::min(32, bytes.len()); | ||
| ssid_bytes[..len].copy_from_slice(bytes); | ||
|
|
||
| Self { | ||
| ssid: ssid_bytes, | ||
| len: len as u8, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Should this use Ssid::from_raw(ssid, len) internally to reduce logic deduplication?
| ssid: ssid_bytes, | ||
| len: len as u8, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not sure what is the proper fix for this (if there's any), but this code currently allows passing UTF-8 strings with double / triple octets characters (like é or emojis), which could be silently truncated at 32 chars.
That being said this isn't unique to this implementation, but rather to how the wifi standards specifies 32 octets, and not 32 chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4924
(this also updates the hard-coded IP address used in examples until #4927 lands)