Remove S2-specific systimer workaround#4993
Merged
bugadani merged 1 commit intoesp-rs:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an ESP32-S2-specific workaround for systimer interrupts that was originally added to handle edge-triggered interrupts. The workaround involved maintaining static handler storage and an intermediate interrupt handler to check which alarm actually triggered. The change simplifies the code by moving the interrupt raw status check into the async handle_alarm function, making the same logic apply to all chips rather than being ESP32-S2-specific.
Changes:
- Removed ESP32-S2-specific workaround code in
set_interrupt_handlerthat used static handler storage and intermediate handlers - Updated
handle_alarmto checkint_raw()before handling the alarm, ensuring handlers only run when the corresponding alarm interrupt is actually set
bugadani
force-pushed
the
s2-systimer
branch
from
a12ad0d to
d060d8a
Compare
bugadani
force-pushed
the
s2-systimer
branch
from
d060d8a to
4d7f405
Compare
bjoernQ
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.