concurrency: resign election on campaign failure#21165
concurrency: resign election on campaign failure#21165davidreis97 wants to merge 1 commit intoetcd-io:mainfrom
Conversation
Ensures that election keys are cleaned up even if the campaign fails. Signed-off-by: David Reis <david.alex.reis.97@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidreis97 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @davidreis97. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #21128.
I chose the approach of calling
e.Resign()immediately since it felt like a "fail safe" way to approach it without leaving dead keys. As mentioned in #21128, keeping thee.leaderSessionand allowing callers to invokee.Resign()would also work but this ensures that we deal with the potential loose keys.I would add an integration test for this but I couldn't figure out a way to cause a failure other than context cancellation, which was already correctly calling
e.Resign(). Any tips are welcome :D