Update CMakeList for Windows build and CI test#74
Open
TheTechsTech wants to merge 3 commits intoeteran:masterfrom
Open
Update CMakeList for Windows build and CI test#74TheTechsTech wants to merge 3 commits intoeteran:masterfrom
TheTechsTech wants to merge 3 commits intoeteran:masterfrom
Conversation
Owner
|
I'll take a look in a little bit! Thanks |
Owner
|
This generally looks good. Just as a heads up, another PR that also at least touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great work!
I had a different vector construction setup, then came across your feature for regular array index access. I scraped/refactored my version in https://github.com/zelang-dev/c-raii/tree/main/src/vector.c to use yours exclusively, memory usage cleanup is automatic though, RAII.
There are a few ideas to make c-vector more expandable, like adding an
enumtype field tovector_metadata_t, macro to set/get.