Add back compute_cells function#534
Merged
jtraglia merged 14 commits intoethereum:mainfrom Feb 18, 2025
Merged
Conversation
jtraglia
commented
Feb 12, 2025
Contributor
|
Thanks for the PR. Is this mostly just a copy-paste of old code? Asking for review purposes. |
Member
Author
Nope. I didn't reference old commits when doing this. For each binding, I just copied the compute cells & proofs method and pasted it into a new compute cells function, then removed the proofs part. For the testing infrastructure, it was pretty much the same idea. Just copy the relevant parts & modify to fit properly. It was all pretty boiler-plate. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have decided to add this method back. Please see:
compute_cellsfunction consensus-specs#4128