Allow n<=1 in bit_reversal_permutation#565
Merged
asn-d6 merged 2 commits intoethereum:mainfrom May 9, 2025
Merged
Conversation
agnxsh
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing
FIELD_ELEMENTS_PER_CELL=1, I got aC_KZG_BADARGSfrombit_reversal_permutationbecause we treated 1 as an invalid length. We just hadn't considered this being valid, but it is. For 0 and 1, we can just return without doing anything. This function is only used with controlled constants, so it shouldn't really affect anything.