Skip to content

Document g1_lincomb_fast() when called as msm([]) #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtraglia merged 1 commit into from
Sep 18, 2025
Merged

Document g1_lincomb_fast() when called as msm([]) #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/common/lincomb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ void g1_lincomb_naive(g1_t *out, const g1_t *p, const fr_t *coeffs, size_t len)
* second is null, and similarly for scalars.
*
* We do the second of these to save memory here.
*
* @remark This function returns G1_IDENTITY if called with the empty set as input.
*/
C_KZG_RET g1_lincomb_fast(g1_t *out, const g1_t *p, const fr_t *coeffs, size_t len) {
C_KZG_RET ret;
Expand Down Expand Up @@ -96,7 +98,7 @@ C_KZG_RET g1_lincomb_fast(g1_t *out, const g1_t *p, const fr_t *coeffs, size_t l
}
}

/* Given zero inputs, we know what the result is */
/* We were either given no inputs, or all zero inputs: return the point at infinity */
if (new_len == 0) {
*out = G1_IDENTITY;
goto out;
Expand Down
Loading