Batch convert commitments/proofs to bytes#626
Open
jtraglia wants to merge 4 commits intoethereum:mainfrom
Open
Batch convert commitments/proofs to bytes#626jtraglia wants to merge 4 commits intoethereum:mainfrom
jtraglia wants to merge 4 commits intoethereum:mainfrom
Conversation
kevaundray
approved these changes
Feb 25, 2026
Contributor
kevaundray
left a comment
There was a problem hiding this comment.
LGTM.
I wonder if we can do the same in recover_cells_and_kzg_proofs
Member
Author
@kevaundray Ah I was too focused on speeding up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
compute_cells_and_kzg_proofs, converting proofs to bytes in batch is 3.44% faster withprecompute=8.Before:
After: