Require gmake in python bindings build for FreeBSD#630
Merged
jtraglia merged 2 commits intoethereum:mainfrom Feb 25, 2026
Merged
Require gmake in python bindings build for FreeBSD#630jtraglia merged 2 commits intoethereum:mainfrom
jtraglia merged 2 commits intoethereum:mainfrom
Conversation
jtraglia
changed the title
kevaundray
reviewed
Feb 25, 2026
setup.py
Outdated
Comment on lines
16
to
17
| if "MAKE" in environ: | ||
| return environ["MAKE"] |
Contributor
There was a problem hiding this comment.
Do we want to put this before the if system() == FreeBSD part, so that if a FreeBSD users sets $MAKE it is honoured?
Member
Author
There was a problem hiding this comment.
Hmm we could. That's probably better. I'll make this change.
Contributor
|
Node error looks unrelated, may just need to restart CI |
kevaundray
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the python bindings, add a
get_make()function which returnsgmakefor FreeBSD systems.Fixes #621.