localkey.py: passwordToKeySHA calls hashPassphraseSHA#398
Open
RKinsey wants to merge 1 commit intoetingof:masterfrom
Open
localkey.py: passwordToKeySHA calls hashPassphraseSHA#398RKinsey wants to merge 1 commit intoetingof:masterfrom
RKinsey wants to merge 1 commit intoetingof:masterfrom
Conversation
|
Cherry picked to lextudio/pysnmp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
passwordToKeySHA has called hashPassphraseMD5 to generate its Ku hashPassphraseMD5 since 130bdaa. This is incorrect under RFC 3414 A.2.2, which uses SHA for both Ku and Kul.
Fortunately, none of the passwordToKey calls are used in the actual library, so this isn't a super urgent fix.