Add support for container types (array, object) when reading JSON files #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would benefit from this too. Edit: now using this PR successfully. |
Contributor
Author
|
Hi again. It looks like the branches diverged, and display conflicts. When there are interests to integrate this patch, we will be happy to resolve them. |
|
@ets could you take a look at merging? |
Owner
LGTM - Happy to merge once the PR is conflict free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Eric,
thanks a stack for conceiving this excellent tap.
We had the need to propagate container types (array and object) from JSON files unmodified, i.e. not serializing them to
strings. This patch implements just that. While being at it, it also adds proper handling forbooleantypes.With kind regards,
Andreas.
NB: A few test cases are failing:
test_handle_newlines_local_excel,test_renamed_https_object,test_smart_columns. It looks like those failures are unrelated to the changes.