Skip to content

Just homework#1411

Closed
aaddaad wants to merge 3 commits intoetternagame:masterfrom
aaddaad:just_homework
Closed

Just homework#1411
aaddaad wants to merge 3 commits intoetternagame:masterfrom
aaddaad:just_homework

Conversation

@aaddaad
Copy link

@aaddaad aaddaad commented Dec 10, 2025

I'm sorry for submitting this request; this is just a course assignment. We made the following changes to the project:

  1. Added Simplified Chinese translation file
    Added the translation file Themes/_fallback/Languages/zh-cn.ini.

  2. Refactored README document structure
    Added a concise project description below the title.

Added a detailed navigation directory for quick access.

Reorganized content from a linear layout into modular categories.

  1. Optimized readability of GameState.cpp code
    Refactored the JoinPlayers function, removing redundant temporary variables.

Simplified the GetNumSidesJoined function to return directly based on boolean members.

Ensured that no external logic was changed, only readability and maintainability were improved.

@poco0317
Copy link
Member

we cant accept this in its current state because

  • the change to the code includes comments none of the active developers can read
  • the readme rewrite is unfinished and not something we need

on its own, the zh-cn language file might be acceptable. i would want to know if you can actually load it ingame. if you can, then we can take it

@poco0317 poco0317 closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants