refactor: visible on scroll directive#2784

Open

LeoniePeters wants to merge 2 commits intomasterfrom

refactor/EC-7261-visible-on-scroll-directive

Contributor

LeoniePeters commented Jun 13, 2025 •

edited

Loading

Fixes bug: when on desktop, scrolled down to hide the header, resizing window to smaller viewport, the header is gone
Refactors the visible-on-scroll directive to use supported js features, and be a cleaner and clearer.


          refactor: fix resize bug and refactor visible on scroll directive

eeb0327

github-actions bot commented Jun 13, 2025

JIRA ticket: EC-7261

github-actions bot commented Jun 13, 2025

Preview deployment: https://pr-2784.portal-js.dev.eanadev.org/


          test: clean up unneeded test

8084b09

sonarqubecloud bot commented Jun 13, 2025

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet