Conversation
Krcnos
left a comment
There was a problem hiding this comment.
Solid addition to the runif command! Just a few feedback changes to make it more intuitive and complete
| end, | ||
|
|
||
| greaterThan = function(text, arg) | ||
| if tonumber(text) > tonumber(arg) then |
There was a problem hiding this comment.
At the moment you'd have to do runIf greaterThan 1 2 command and it would return true as 2 is greater than 1 but I think tonumber(text) > tonumber(arg) should be switched to tonumber(arg) > tonumber(text) to be a little more intuitive as you're comparing the argument against the text
| end, | ||
|
|
||
| lessThan = function(text, arg) | ||
| if tonumber(text) < tonumber(arg) then |
There was a problem hiding this comment.
Same as line 39 comment, switch them
| end, | ||
|
|
||
| greaterThanOrEqual = function(text, arg) | ||
| if tonumber(text) >= tonumber(arg) then |
There was a problem hiding this comment.
Same as line 39 comment, switch them
| end, | ||
|
|
||
| lessThanOrEqual = function(text, arg) | ||
| if tonumber(text) <= tonumber(arg) then |
There was a problem hiding this comment.
Same as line 39 comment, switch them
|
@wilyt1 have you considered the comments from krcnos? |
|
I've reviewed the feedback and explained why implementing those suggestions wouldn't work right now, mainly because of how the |
This pull request expands on the features mentioned in issue #25 by adding more conditions.
Declarations: