Conversation
schreibubi
force-pushed
the
openwb
branch
2 times, most recently
from
f844996 to
9ccdb3e
Compare
ngehrsitz
left a comment
ngehrsitz
left a comment
There was a problem hiding this comment.
👍 for getting out-of the-box OpenWB support
userpatches/customize-image.sh
Outdated
| # Pre-generate minimal config if missing | ||
| if [[ ! -f /etc/evcc.yaml ]]; then | ||
| cat >/etc/evcc.yaml <<YAML | ||
| cat >/etc/evcc.yaml <<YAML |
There was a problem hiding this comment.
We could also pre-generate the config from evcc-io/evcc#21984
The only thing missing to avoid manual configuration would be smart meter detection which is why I suggested auto-detecting that in code.
|
@ngehrsitz Can you please go and re-review the latest changes? Since evcc now contains the OpenWB support, it would be nice to have the corresponding images available. |
userpatches/customize-image.sh
Outdated
| else | ||
| cat >/etc/evcc.yaml <<YAML | ||
| network: | ||
| schema: httpslocal | ||
| host: ${EVCC_HOSTNAME}. |
There was a problem hiding this comment.
Why is httpslocal differnt here? Can´t we get rid of the else case by always creating the network section and only conditionally append the openwb block.
build-local.sh
Outdated
| - rpi4b Raspberry Pi 4B | ||
| - nanopi-r3s NanoPi R3S | ||
| - openwb OpenWB without display | ||
| - openwb-display OpenWB with display |
There was a problem hiding this comment.
I noticed that the board deinitions are used in five places already.
- Here
- L62
- L67
- scripts/build-armbian.sh L24
- .github/workflows/release.yml L42
Thus I think it would be a good idea to load them from all of the config-*.conf.sh files
|
Images built through github actions can be found here: https://github.com/schreibubi/images/releases/tag/v2026-01.1 |
2 participants
Initial draft of building Armbian images which support openWB