Skip to content

feat(loader): use new ExtensionLoader#83

Merged
mharrisb1 merged 4 commits intoevidence-dev:mainfrom
mharrisb1:chore/upgrade-to-v1.3.2
Jul 16, 2025
Merged

feat(loader): use new ExtensionLoader#83
mharrisb1 merged 4 commits intoevidence-dev:mainfrom
mharrisb1:chore/upgrade-to-v1.3.2

Conversation

@mharrisb1
Copy link
Collaborator

Needed to move over to using duckdb/duckdb#17772 to get this working with DuckDB v1.3.2

Needed to move over to using duckdb/duckdb#17772
to get this working with DuckDB v1.3.2
@mharrisb1 mharrisb1 requested a review from Copilot July 16, 2025 17:40
@mharrisb1 mharrisb1 self-assigned this Jul 16, 2025
@mharrisb1 mharrisb1 added the enhancement New feature or request label Jul 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the gsheets extension from using the legacy DuckDB extension loading interface to the new ExtensionLoader API, required for compatibility with DuckDB v1.3.2. The changes replace DatabaseInstance parameters with ExtensionLoader and update the extension initialization pattern.

  • Updates function signatures to use ExtensionLoader instead of DatabaseInstance
  • Replaces ExtensionUtil function calls with direct loader method calls
  • Modernizes the extension entry point to use DUCKDB_CPP_EXTENSION_ENTRY macro

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/include/gsheets_extension.hpp Updates Load method signature to accept ExtensionLoader
src/include/gsheets_auth.hpp Updates Register method signature for secret functions
src/gsheets_extension.cpp Migrates extension loading logic to new API and updates entry point
src/gsheets_auth.cpp Updates secret registration to use new loader interface
duckdb Updates DuckDB submodule to newer version
.gitmodules Updates submodule branches to main
.github/workflows/MainDistributionPipeline.yml Updates CI to use DuckDB v1.3.2
Comments suppressed due to low confidence (3)

src/gsheets_auth.cpp:136

  • The CreateSecretFunction constructor call is missing the required fourth parameter. Based on the updated calls on lines 136, 142, and 148, an empty braces {} should be added as the fourth parameter to match the new API signature.
        CreateSecretFunction access_token_function = {type, "access_token", CreateGsheetSecretFromAccessToken, {}};

src/gsheets_auth.cpp:142

  • The CreateSecretFunction constructor call is missing the required fourth parameter. Based on the pattern shown in other lines, an empty braces {} should be added as the fourth parameter to match the new API signature.
        CreateSecretFunction oauth_function = {type, "oauth", CreateGsheetSecretFromOAuth, {}};

src/gsheets_auth.cpp:148

  • The CreateSecretFunction constructor call is missing the required fourth parameter. Based on the pattern shown in other lines, an empty braces {} should be added as the fourth parameter to match the new API signature.
        CreateSecretFunction key_file_function = {type, "key_file", CreateGsheetSecretFromKeyFile, {}};

@mharrisb1 mharrisb1 linked an issue Jul 16, 2025 that may be closed by this pull request
@mharrisb1 mharrisb1 merged commit e3412a2 into evidence-dev:main Jul 16, 2025
22 checks passed
@mharrisb1 mharrisb1 deleted the chore/upgrade-to-v1.3.2 branch July 16, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DuckDB 1.3.0

1 participant