feat(loader): use new ExtensionLoader#83
Merged
mharrisb1 merged 4 commits intoevidence-dev:mainfrom Jul 16, 2025
Merged
Conversation
Needed to move over to using duckdb/duckdb#17772 to get this working with DuckDB v1.3.2
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the gsheets extension from using the legacy DuckDB extension loading interface to the new ExtensionLoader API, required for compatibility with DuckDB v1.3.2. The changes replace DatabaseInstance parameters with ExtensionLoader and update the extension initialization pattern.
- Updates function signatures to use
ExtensionLoaderinstead ofDatabaseInstance - Replaces
ExtensionUtilfunction calls with directloadermethod calls - Modernizes the extension entry point to use
DUCKDB_CPP_EXTENSION_ENTRYmacro
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/include/gsheets_extension.hpp |
Updates Load method signature to accept ExtensionLoader |
src/include/gsheets_auth.hpp |
Updates Register method signature for secret functions |
src/gsheets_extension.cpp |
Migrates extension loading logic to new API and updates entry point |
src/gsheets_auth.cpp |
Updates secret registration to use new loader interface |
duckdb |
Updates DuckDB submodule to newer version |
.gitmodules |
Updates submodule branches to main |
.github/workflows/MainDistributionPipeline.yml |
Updates CI to use DuckDB v1.3.2 |
Comments suppressed due to low confidence (3)
src/gsheets_auth.cpp:136
- The CreateSecretFunction constructor call is missing the required fourth parameter. Based on the updated calls on lines 136, 142, and 148, an empty braces
{}should be added as the fourth parameter to match the new API signature.
CreateSecretFunction access_token_function = {type, "access_token", CreateGsheetSecretFromAccessToken, {}};
src/gsheets_auth.cpp:142
- The CreateSecretFunction constructor call is missing the required fourth parameter. Based on the pattern shown in other lines, an empty braces
{}should be added as the fourth parameter to match the new API signature.
CreateSecretFunction oauth_function = {type, "oauth", CreateGsheetSecretFromOAuth, {}};
src/gsheets_auth.cpp:148
- The CreateSecretFunction constructor call is missing the required fourth parameter. Based on the pattern shown in other lines, an empty braces
{}should be added as the fourth parameter to match the new API signature.
CreateSecretFunction key_file_function = {type, "key_file", CreateGsheetSecretFromKeyFile, {}};
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to move over to using duckdb/duckdb#17772 to get this working with DuckDB v1.3.2