Update to latest DuckDB packages#3245
Conversation
…s use the buildId identifier
abc6798 to
e23de23
Compare
|
huge PR, thank you! |
archiewood
left a comment
There was a problem hiding this comment.
This is kind of two changes
-
Relatively low risk: Upgrade the DuckDB connector to use the node-api. This only affects the DuckDB connector and the writing of parquet files using that.
-
Relatively high risk: Upgrade WASM. This impacts the SQL runtime for the whole of Evidence and merits some careful checking
I think that the risk is kind of flipped. The WASM update is a drop-in replacement and stuff just works (as far as I can tell). I have been running the new WASM packages for some time now and nothing has broken. The switch to |
|
I pushed a new commit that uses the stable releases as of today.
|
|
looks like you need to regenerate the lockfile
How old we talking? WASM sometimes lags duckdb
I guess I was thinking more about the risk to the product as a whole. Impacting the duckdb connector vs impacting the runtime. I take your point around the complexity |
545149a to
0266017
Compare
Done and forced pushed.
https://www.npmjs.com/package/@duckdb/duckdb-wasm?activeTab=versions It looks like 1.30.0 was released 2 months ago, 1.31.0 1 month ago, and 1.31.1-dev31.0 yesterday (probably to line up with 1.4.2). |
|
seems like some legitimate tests failing in universal-sql to do with parquet writing https://github.com/evidence-dev/evidence/actions/runs/19345379304/job/55344745970 |
|
I thought I did run format and added a changeset. I might have removed them when I forced pushed yesterday. |
|
Yeah. These fail also on main. I fixed them in #3243. Would you rather just merge the two pull requests into one? |
0821ba5 to
33f57c4
Compare
33f57c4 to
4db0827
Compare
|
thank you for this! |
Description
The DuckDB packages have been updated to their latest versions:
duckdb-async has been replaced with duckdb/node-api. This led to some changes in how queries
are run and how results are processed. The new duckdb/node-api package offers improved performance
and follows the same release schedule as the main DuckDB project. duckdb-async will be discontinued in
about 6 months.
Additional tests have been added to ensure that semicolons inside block comments do not split SQL
statements incorrectly.
The new packages work on my production site. There might be remaining bugs with the duckdb/node-api implementation, but I haven't run into them yet.
The duckdb-wasm update is a drop-in replacement for the old one.
Checklist