Conversation
AlKaliada
requested review from
Alexey-Chernyakov,
ala-n,
aliakseiTraihel,
liubou-masiuk,
mhoroshko,
nattallius and
smiakchilo
| action="foundation.dialog" | ||
| target=".eqk-ui" | ||
| action="foundation.link" | ||
| href="/mnt/overlay/commerce/gui/content/v2/catalogs/createcatalogwizard.html${requestPathInfo.suffix}" |
There was a problem hiding this comment.
Something's wrong with link, yeah?) Why "create catalog wizard"?
There was a problem hiding this comment.
sorry, it's a typo)
| nesting="hide" | ||
| src.url="/mnt/overlay/etoolbox-query-kit/console/dialogs/settings.html"/> | ||
| </settings> | ||
| <statistic |
There was a problem hiding this comment.
(spelling) It is always "statistics"
There was a problem hiding this comment.
fixed, thank you!
| @@ -0,0 +1,95 @@ | |||
| <sly data-sly-use.queryStatisticModel="com.exadel.etoolbox.querykit.core.models.query.QueryStatisticModel"></sly> | |||
There was a problem hiding this comment.
(spelling) Please rename to "...statistics" everywhere
| ${queryStatisticModel.indexesByUsage[index]} | ||
| </sly> | ||
|
|
||
| <!--/*<ul data-sly-list.index="${queryStatisticModel.indexesByUsage}">*/--> |
There was a problem hiding this comment.
no, it was just for demo. Deleted unused code
| private LinkedHashMap<String, List<QueryStatisticModel.QueryInfo>> queriesByIndexSorted = new LinkedHashMap<>(); | ||
|
|
||
| @PostConstruct | ||
| protected void init() throws IOException { |
| Set<ObjectName> names = server.queryNames(new ObjectName("org.apache.jackrabbit.oak:type=QueryStats,*"), null); | ||
| return names.iterator().next(); | ||
| } catch (IOException | MalformedObjectNameException | NoSuchElementException e) { | ||
| return null; |
There was a problem hiding this comment.
Need to add logging here
| } | ||
|
|
||
| private String getIndexId(String value) { | ||
| if (value.contains("(") && value.contains(")")) { |
There was a problem hiding this comment.
Please use Constants.OPENING_BRACKET, etc. (and please review other places when existing constants could be used
| } | ||
| } | ||
|
|
||
| public static class QueryInfo { |
There was a problem hiding this comment.
- I'd rather extracted into a separate class file
- Please refactor to use Lombok. It's Lombok throughout this project
| <clientlibs | ||
| jcr:primaryType="nt:unstructured" | ||
| sling:resourceType="granite/ui/components/coral/foundation/includeclientlibs" | ||
| categories="[cq.common.wcm,cq.listview.coral.columns.personalization,cq.siteadmin.admin.page.row,cq.gui.coral.common.admin.references,cq.screens.dcc,etoolbox-query-kit.queryStatistic]"/> |
There was a problem hiding this comment.
Do we need all these categories here? They look like too much
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Let us move to the main clientlibs folder. The rest of css/js in one place. I frankly see no big reason fo these two rules to be in another
3 participants
No description provided.