Skip to content

Moviegoer and SimpleCalculator accept exceptions from both scopes #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VaiaPatta1985 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Moviegoer and SimpleCalculator accept exceptions from both scopes #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exercises/concept/moviegoer/moviegoer_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ def test_members_get_free_popcorn
end

def test_regular_moviegoers_dont_get_free_popcorn
assert_raises NotMovieClubMemberError do
expected_exception=Moviegoer.include?(NotMovieClubMemberError)?(Moviegoer::NotMovieClubMemberError):NotMovieClubMemberError
assert_raises expected_exception do
Moviegoer.new(25, member: false).claim_free_popcorn!
end
end
Expand Down
9 changes: 6 additions & 3 deletions exercises/concept/simple-calculator/simple_calculator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,17 @@ def test_no_number_second_operand_raises_exception
end

def test_raises_exception_for_non_valid_operations
assert_raises(SimpleCalculator::UnsupportedOperation) { SimpleCalculator.calculate(1, 2, '**') }
expected_exception=SimpleCalculator.include?(UnsupportedOperation)?(SimpleCalculator::UnsupportedOperation):UnsupportedOperation
assert_raises(expected_exception) { SimpleCalculator.calculate(1, 2, '**') }
end

def test_raises_exception_when_operation_is_nil
assert_raises(SimpleCalculator::UnsupportedOperation) { SimpleCalculator.calculate(1, 2, nil) }
expected_exception=SimpleCalculator.include?(UnsupportedOperation)?(SimpleCalculator::UnsupportedOperation):UnsupportedOperation
assert_raises(expected_exception) { SimpleCalculator.calculate(1, 2, nil) }
end

def test_raises_exception_when_operation_is_an_empty_string
assert_raises(SimpleCalculator::UnsupportedOperation) { SimpleCalculator.calculate(1, 2, '') }
expected_exception=SimpleCalculator.include?(UnsupportedOperation)?(SimpleCalculator::UnsupportedOperation):UnsupportedOperation
assert_raises(expected_exception) { SimpleCalculator.calculate(1, 2, '') }
end
end
Loading