feat: dump bodies of get/head reqs#6742
Draft
O4FDev wants to merge 4 commits intoexpressjs:masterfrom
Draft
Conversation
O4FDev
force-pushed
the
feat/dump-bodies-get-head
branch
from
ebdc120 to
0cdd3e3
Compare
ronag
reviewed
Sep 5, 2025
Co-authored-by: Robert Nagy <ronagy@icloud.com>
Member
Author
|
Pushing the CI timeout so I don't inadvertently annoy the maintainers by wasting 6h of actions time per test, not intending for that to go out in this PR and I'm currently investigating why it hangs |
bjohansebas
reviewed
Sep 14, 2025
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
I feel like we need to change something in the router, because it seems that unknown routes aren't being resolved, which technically would also be a problem for those who are going to use this option from Node.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on nodejs/node#59747