Draft
Conversation
Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| :root { | ||
| /* Font Families */ | ||
| --font-family-sans: | ||
| 'Helvetica Neue', Helvetica, Arial, system-ui, -apple-system, BlinkMacSystemFont, sans-serif; |
Member
There was a problem hiding this comment.
Just want to highlight, this root/body font is inconsistent across platforms.
WDYT, sans-serif variable font?
| ============================================ */ | ||
|
|
||
| /* Device-specific (exclusive) */ | ||
| @custom-media --xs-only (width < 768px); |
Member
There was a problem hiding this comment.
I think we should use rem instead of hard points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The conflicts will be resolved when we’re ready to release it to the public, so don’t worry about that—one of the captains will handle it when the time comes.
Note to self: I’ll update the description later, once we’ve made some progress, okay.