feat: add OpenJS trademark notice to footer (fixes #2172) #2178
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: omerbakr <y.omerbakir@gmail.com>
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
carlosstenzel
approved these changes
Feb 4, 2026
ShubhamOulkar
approved these changes
Feb 4, 2026
| <a id="coc" href="https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md"> | ||
| {{ site.data[page.lang].footer.coc }} | ||
| </a> | ||
| <a href="https://trademark-policy.openjsf.org"> |
Member
There was a problem hiding this comment.
Should we remove this duplicated trademark policy link?
cc @expressjs/docs-captains
Member
|
Thank you @omerbakr for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the footer to include the required OpenJS Foundation trademark notice as requested in issue #2172.
Changes Made
_data/en.yml._includes/footer.htmlto display the text.#footer-trademark-legalincss/style.cssto style the text (opacity, font-size) consistent with the footer design.Since this is a legal trademark notice, I assumed it should remain in English for all locales unless an official translation is provided.
Instead of duplicating the English text across all language files (
es.yml,fr.yml, etc.) which would violate DRY principles, I implemented a Liquid fallback in the footer template:{{ site.data[page.lang].footer.trademark_legal | default: site.data.en.footer.trademark_legal }}