Open
Conversation
Member
Author
|
I don't see any way the code can cause the test failures (unless we actually use TRACE/TRACK in tests). Ready for review. |
alongosz
approved these changes
Jul 15, 2022
konradoboza
approved these changes
Jul 15, 2022
adamwojs
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://issues.ibexa.co/browse/IBX-2921
Disable TRACE/TRACK methods. Browsers have blocked this already for ages now, but explicitly blocking it in vhosts can silence some test warnings. Proposal by @vidarl, I just added case insensitivity.