feat: Add support for reversed attribute on ol elements#469
Open
dereuromark wants to merge 1 commit intoezyang:masterfrom
Open
feat: Add support for reversed attribute on ol elements#469dereuromark wants to merge 1 commit intoezyang:masterfrom
dereuromark wants to merge 1 commit intoezyang:masterfrom
Conversation
Move the start attribute from Legacy module to the core List module and add the reversed boolean attribute. Both are standard HTML5 attributes and should be available by default. Fixes ezyang#468
dereuromark
changed the title
Author
|
ping @ezyang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reversedboolean attribute to<ol>elementsstartattribute from Legacy module to the core List moduleBoth
reversedandstartare standard HTML5 attributes (not deprecated), so they should be available by default without requiring the Legacy module.Reasoning:
The type attribute on
<ol>(1, i, I, a, A) is considered a presentational attribute - it controls thevisual style of list markers, which is better handled by CSS (list-style-type). That's why it's in the
Legacy module alongside deprecated/presentational attributes like compact, align, bgcolor, etc.
In contrast:
Fixes #468