fix: PHP 8.1+ null parameter deprecation warnings in Generator.php#477
Open
sysmonf wants to merge 1 commit intoezyang:masterfrom
Open
fix: PHP 8.1+ null parameter deprecation warnings in Generator.php#477sysmonf wants to merge 1 commit intoezyang:masterfrom
sysmonf wants to merge 1 commit intoezyang:masterfrom
Conversation
Add null coalescing operator (?? '') to prevent deprecation warnings on PHP 8.1-8.4 and TypeError on PHP 8.5+ when null is passed to built-in string functions. Changes: - generateAttributes(): strpos(), strcspn(), strlen() with null $value - escape(): htmlspecialchars() with null $string - Flash compat: $token->attr['name'] / $token->attr['value'] may not exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add null coalescing operator (?? '') to prevent deprecation warnings on PHP 8.1-8.4 and TypeError on PHP 8.5+ when null is passed to built-in string functions.
Of note, htmlpurifier was ran on tens of thousands of html code using PHP 8.5, and this is all the deprecation errors we noted on PHP 8.5.
Changes: