[Feature/dispatch-rider] 라이더 매칭 기능 구현 #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-bright
approved these changes
Dec 31, 2022
Collaborator
f-lab-bright
left a comment
f-lab-bright
left a comment
There was a problem hiding this comment.
LGTM with comments
Comment on lines
+35
to
+42
| .map(r -> | ||
| RiderMatchedEvent.builder() | ||
| .riderId(r.getId()) | ||
| .deliveryId(delivery.getId()) | ||
| .orderId(delivery.getOrderId()) | ||
| .build() | ||
| ) | ||
| .forEach(e -> eventPublisher.publishEvent(e)); |
Collaborator
There was a problem hiding this comment.
이 부분은 이벤트의 목록을 재사용하는게 아니라면 forEach 하나로 묶어도 되긴 하겠네요
| "주어진 식별자에 해당하는 가게가 없습니다. 가게 ID = " + delivery.getShopId() | ||
| )); | ||
|
|
||
| jpaRiderRepository.findAll().stream() |
Collaborator
There was a problem hiding this comment.
라이더수가 많다면 oome가 발생할 수도 있긴 할텐데, 이 부분은 어떻게 최적화할지도 고민해보면 좋겠네요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
전체 라이더를 조회하고 가게와의 거리를 계산해 매칭된 라이더에게 이벤트를 발행하도록 구현