Skip to content

Added time as a uniform property for final shader#2793

Open
RealEdwardS wants to merge 2 commits intof3d-app:masterfrom
RealEdwardS:final-shader-improvements
Open

Added time as a uniform property for final shader#2793
RealEdwardS wants to merge 2 commits intof3d-app:masterfrom
RealEdwardS:final-shader-improvements

Conversation

@RealEdwardS
Copy link

Describe your changes

Added time elapsed from the app start as a uniform property for final shader application.

time is stored as a double, however, there doesn't seem to be a SetUniform function for doubles (according to the docs - https://vtk.org/doc/nightly/html/classvtkUniforms.html), so I'm using SetUniformf.

Issue ticket number and link if any

#2257

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@RealEdwardS RealEdwardS marked this pull request as draft January 8, 2026 01:37
@RealEdwardS RealEdwardS marked this pull request as ready for review January 8, 2026 02:38
@Meakk
Copy link
Member

Meakk commented Jan 8, 2026

Nice straightforward implementation :)
You will have to add a simple test using time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants